Skip to content

GraphPPL version 4.0.0#204

Merged
bvdmitri merged 714 commits intomainfrom
dev-4.0.0
Apr 3, 2024
Merged

GraphPPL version 4.0.0#204
bvdmitri merged 714 commits intomainfrom
dev-4.0.0

Conversation

@wouterwln
Copy link
Member

This PR reimplements GraphPPL to explicitly construct a factor graph representation of models. This allows nested models and a nicer model macro. This PR also adds tests and documentation to the new version

wouterwln and others added 30 commits March 4, 2024 15:55
Use same unique call for partition check and constraint materialization
Add compile time keys for the extra properties of graph nodes
@wouterwln wouterwln requested a review from bvdmitri April 3, 2024 09:42
@wouterwln wouterwln linked an issue Apr 3, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 91.81771% with 158 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@fca0b4b). Click here to learn what that means.

Files Patch % Lines
src/graph_engine.jl 89.23% 77 Missing ⚠️
src/model_macro.jl 88.81% 34 Missing ⚠️
...onal_constraints/variational_constraints_engine.jl 95.02% 22 Missing ⚠️
src/plugins/meta/meta_engine.jl 87.09% 12 Missing ⚠️
...ional_constraints/variational_constraints_macro.jl 94.11% 5 Missing ⚠️
src/resizable_array.jl 97.60% 3 Missing ⚠️
src/plugins/meta/meta.jl 87.50% 2 Missing ⚠️
src/plugins/meta/meta_macro.jl 95.12% 2 Missing ⚠️
src/plugins_collection.jl 95.83% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage        ?   91.82%           
=======================================
  Files           ?       15           
  Lines           ?     1932           
  Branches        ?        0           
=======================================
  Hits            ?     1774           
  Misses          ?      158           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wouterwln wouterwln linked an issue Apr 3, 2024 that may be closed by this pull request
Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @wouterwln

@wouterwln wouterwln linked an issue Apr 3, 2024 that may be closed by this pull request
@bvdmitri bvdmitri merged commit 648bd87 into main Apr 3, 2024
@bvdmitri bvdmitri deleted the dev-4.0.0 branch April 3, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants